[PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup()

Wei Yongjun weiyj.lk at gmail.com
Fri Nov 16 13:21:20 EST 2012


On 11/15/2012 08:08 PM, Grant Likely wrote:
> On Thu, 1 Nov 2012 13:27:34 +0800, Wei Yongjun <weiyj.lk at gmail.com> wrote:
>> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>>
>> In case of error, the function clk_get() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value
>> check should be replaced with IS_ERR().
>>
>> dpatch engine is used to auto generate this patch.
>> (https://github.com/weiyj/dpatch)
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> Looks correct to me.
>
> Acked-by: Grant Likely <grant.likely at secretlab.ca>
>
> Alan, which tree should this go through?
>
> Wei, did you run into this causing a bug? Do you think it should go back
> into linux-stable? It looks like it should to me.

Hi,

this only happens in the -next tree, so I think no need for stable.
 



More information about the devicetree-discuss mailing list