[PATCH v2] usb: host: tegra: remove pointless NULL check in tegra_ehci_remove()

[Alan Stern]

On Thu, 8 Nov 2012, Wei Yongjun wrote:

> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> 
> Test for tegra and hcd in tegra_ehci_remove() look like potential
> NULL pointer dereference, but in fact those tests are not needed,
> so remove these pointless tests entirely.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
> v1 -> v2: remove those tests entirely
> ---
>  drivers/usb/host/ehci-tegra.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 6223d175..40daeaa 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -778,9 +778,6 @@ static int tegra_ehci_remove(struct platform_device *pdev)
>  	struct tegra_ehci_hcd *tegra = platform_get_drvdata(pdev);
>  	struct usb_hcd *hcd = ehci_to_hcd(tegra->ehci);
>  
> -	if (tegra == NULL || hcd == NULL)
> -		return -EINVAL;
> -
>  	pm_runtime_get_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);

Acked-by: Alan Stern <stern at rowland.harvard.edu>