[PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

David Gibson david at gibson.dropbear.id.au
Wed Nov 7 10:29:20 EST 2012


On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
> 
> Not all /bin/echo implementations support the -e option. Instead, use
> printf, which appears to be more widely available than /bin/echo -e.
> 
> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
> bash" for history.
> 
> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
> and bash.
> 
> Reported-by: Mike Frysinger <vapier at gentoo.org> # and implemented-by
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
> Mike, should I re-write this with you as the git author? If so, could
> you please supply an S-o-b line for this?
> ---
>  tests/fdtget-runtest.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> index c3a3559..8d8b058 100755
> --- a/tests/fdtget-runtest.sh
> +++ b/tests/fdtget-runtest.sh
> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
>  trap "rm -f $LOG $EXPECT" 0
>  
>  expect="$1"
> -/bin/echo -e $expect >$EXPECT
> +printf '%b\n' "$expect" > $EXPECT

Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
that was never committed..

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson


More information about the devicetree-discuss mailing list