[PATCH v2 08/12] ARM: imx6q: add usbphy clocks

Richard Zhao richard.zhao at freescale.com
Tue May 22 14:59:35 EST 2012


On Tue, May 22, 2012 at 06:32:13AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
> 
> Maybe reorder this so it's in before the PHY driver?
Patch series always driver come first.
> 
> Reviewed-by: Marek Vasut <marex at denx.de>
> 
> > Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> > ---
> >  arch/arm/mach-imx/clk-imx6q.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
> > index f99509a..0d003aa 100644
> > --- a/arch/arm/mach-imx/clk-imx6q.c
> > +++ b/arch/arm/mach-imx/clk-imx6q.c
> > @@ -152,7 +152,7 @@ enum mx6q_clks {
> >  	ssi2, ssi3, uart_ipg, uart_serial, usboh3, usdhc1, usdhc2, usdhc3,
> >  	usdhc4, vdo_axi, vpu_axi, cko1, pll1_sys, pll2_bus, pll3_usb_otg,
> >  	pll4_audio, pll5_video, pll6_mlb, pll7_usb_host, pll8_enet, ssi1_ipg,
> > -	ssi2_ipg, ssi3_ipg, clk_max
> > +	ssi2_ipg, ssi3_ipg, usbphy1_gate, usbphy2_gate, clk_max
> >  };
> > 
> >  static struct clk *clk[clk_max];
> > @@ -197,6 +197,9 @@ int __init mx6q_clocks_init(void)
> >  	clk[pll7_usb_host] = imx_clk_pllv3(IMX_PLLV3_USB,	
> "pll7_usb_host","osc",
could you disable auto-wrap?

Thanks
Richard
> > base + 0x20, 0x2000,   0x3); clk[pll8_enet]     =
> > imx_clk_pllv3(IMX_PLLV3_ENET,	"pll8_enet",	"osc", base + 0xe0, 0x182000,
> > 0x3);
> > 
> > +	clk[usbphy1_gate] = imx_clk_gate("usbphy1_gate", "pll3_usb_otg", base +
> > 0x10, 6); +	clk[usbphy2_gate] = imx_clk_gate("usbphy2_gate",
> > "pll7_usb_host", base + 0x20, 6); +
> >  	/*                                name              parent_name       
> > reg       idx */ clk[pll2_pfd0_352m] = imx_clk_pfd("pll2_pfd0_352m",
> > "pll2_bus",     base + 0x100, 0); clk[pll2_pfd1_594m] =
> > imx_clk_pfd("pll2_pfd1_594m", "pll2_bus",     base + 0x100, 1); @@ -395,6
> > +398,8 @@ int __init mx6q_clocks_init(void)
> >  	clk_register_clkdev(clk[usboh3], NULL, "2184200.usb");
> >  	clk_register_clkdev(clk[usboh3], NULL, "2184400.usb");
> >  	clk_register_clkdev(clk[usboh3], NULL, "2184600.usb");
> > +	clk_register_clkdev(clk[usbphy1_gate], NULL, "20c9000.usbphy");
> > +	clk_register_clkdev(clk[usbphy2_gate], NULL, "20ca000.usbphy");
> >  	clk_register_clkdev(clk[uart_serial], "per", "2020000.serial");
> >  	clk_register_clkdev(clk[uart_ipg], "ipg", "2020000.serial");
> >  	clk_register_clkdev(clk[uart_serial], "per", "21e8000.serial");
> 
> Best regards,
> Marek Vasut
> 



More information about the devicetree-discuss mailing list