[PATCH 1/2] iommu/tegra: smmu: Simplify allocation at once

Stephen Warren swarren at wwwdotorg.org
Tue May 15 09:34:15 EST 2012


On 05/14/2012 01:16 PM, Hiroshi DOYU wrote:
> To simplify the code, alloc necessary data at once.
> 
> Signed-off-by: Hiroshi DOYU <hdoyu at nvidia.com>
> ---
> This patch requires:
> 
>     [PATCH 1/2] iommu/tegra: smmu: Add device tree support for SMMU
>         http://marc.info/?l=linux-tegra&m=133663641107327&w=2
> 
> Also the above patch requires:
> 
>     [PATCH 1/1] dt: Add general DMA window parser
>         http://marc.info/?l=linux-tegra&m=133671302703840&w=2

I know I've been harping on about dependencies, but you typically only
need to mention them if the dependencies are not already checked into
the branch you expect this patch to be checked into.

> -	smmu = devm_kzalloc(dev, sizeof(*smmu), GFP_KERNEL);
> +	if (of_property_read_u32(dev->of_node, "nvidia,#asids", &asids))
> +		return -ENODEV;

I believe you need to change the asids variable from int to u32 to avoid
a warning here.

Aside from that, the series,
Acked-by: Stephen Warren <swarren at wwwdotorg.org>


More information about the devicetree-discuss mailing list