[PATCH] Input: tl6040-vibra: Device Tree support
Dmitry Torokhov
dmitry.torokhov at gmail.com
Mon May 7 17:02:34 EST 2012
Hi Peter,
On Fri, May 04, 2012 at 03:05:13PM +0300, Peter Ujfalusi wrote:
> + if (pdata) {
> + info->vibldrv_res = pdata->vibldrv_res;
> + info->vibrdrv_res = pdata->vibrdrv_res;
> + info->viblmotor_res = pdata->viblmotor_res;
> + info->vibrmotor_res = pdata->vibrmotor_res;
> + vddvibl_uV = pdata->vddvibl_uV;
> + vddvibr_uV = pdata->vddvibr_uV;
> + } else {
> + of_property_read_u32(node, "vibldrv_res", &info->vibldrv_res);
> + of_property_read_u32(node, "vibrdrv_res", &info->vibrdrv_res);
> + of_property_read_u32(node, "viblmotor_res",
> + &info->viblmotor_res);
> + of_property_read_u32(node, "vibrmotor_res",
> + &info->vibrmotor_res);
Since these 4 appear to be mandatory properties don't we need to
validate they are actually present in DT?
Thanks.
--
Dmitry
More information about the devicetree-discuss
mailing list