[PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic
Dong Aisheng
aisheng.dong at freescale.com
Mon May 7 13:55:59 EST 2012
On Sat, May 05, 2012 at 10:32:14PM +0800, Marek Vasut wrote:
> Dear Shawn Guo,
>
> > On 5 May 2012 21:12, Marek Vasut <marex at denx.de> wrote:
> > > Can't the patches be reordered then to avoid adding this altogether?
> >
> > Maybe. But I do not think it's really worth the effort.
> >
> > > You don't have to add dead code in this patch and re-add it when needed.
> > > Or fix the macro to take the parameter then, though I don't understand
> > > why you'd want to take it and then hide it.
> >
> > I do not completely understand the comment. My point is the problem
> > is in the existing code. It's not introduced by Dong's patch. The
> > problem should be fixed in another patch, and we do not want to do
> > several things in one patch.
>
> Then order such a patch before Dong's series then? It'd all be clear, without
> compromises.
>
Hmm, although not a big issue, but i can re-oder it to make most people happy with
the patch.
Thanks
Regards
Dong Aisheng
More information about the devicetree-discuss
mailing list