[PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic

Shawn Guo shawn.guo at linaro.org
Sat May 5 23:25:20 EST 2012


On 5 May 2012 21:12, Marek Vasut <marex at denx.de> wrote:
> Can't the patches be reordered then to avoid adding this altogether?
>
Maybe.  But I do not think it's really worth the effort.

> You don't have to add dead code in this patch and re-add it when needed. Or fix
> the macro to take the parameter then, though I don't understand why you'd want
> to take it and then hide it.
>
I do not completely understand the comment.  My point is the problem
is in the existing code.  It's not introduced by Dong's patch.  The
problem should be fixed in another patch, and we do not want to do
several things in one patch.

Regards,
Shawn


More information about the devicetree-discuss mailing list