[PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic
Shawn Guo
shawn.guo at linaro.org
Sat May 5 00:34:44 EST 2012
On Fri, May 04, 2012 at 02:15:03PM +0200, Marek Vasut wrote:
> > static int __init mxs_add_mxs_dma(void)
> > {
> > - char *apbh = "mxs-dma-apbh";
> > - char *apbx = "mxs-dma-apbx";
> > + char *mx23_apbh = "imx23-dma-apbh";
> > + char *mx23_apbx = "imx23-dma-apbx";
> > + char *mx28_apbh = "imx28-dma-apbh";
> > + char *mx28_apbx = "imx28-dma-apbx";
>
> Wild guess ... but const char * won't hurt here ?
>
Right. I guess it just followed how the existing code looks like.
Considering this whole function will be removed patch #4, it should
not be a big problem, I guess.
> > -#define MXS_DMA_APBH 0
> > -#define MXS_DMA_APBX 1
> > -#define dma_is_apbh() (mxs_dma->dev_id == MXS_DMA_APBH)
> > -
> > -#define APBH_VERSION_LATEST 3
> > -#define apbh_is_old() (mxs_dma->version < APBH_VERSION_LATEST)
> > +#define dma_is_apbh() (mxs_dma->type == MXS_DMA_APBH)
> > +#define apbh_is_old() (mxs_dma->dev_id == IMX23_DMA)
> >
...
> > +int mxs_dma_is_apbh(struct dma_chan *chan)
> > +{
> > + struct mxs_dma_chan *mxs_chan = to_mxs_dma_chan(chan);
> > + struct mxs_dma_engine *mxs_dma = mxs_chan->mxs_dma;
>
> Do you need the above here ? :)
>
I have to confess it's my bad. I made the code hard to read when I
created the driver. The dma_is_apbh() should really takes mxs_dma
as a parameter than hiding it in the macro.
While I agree this is something should be improved, it may be better
to do it in another patch?
> > +
> > + return dma_is_apbh();
> > +}
--
Regards,
Shawn
More information about the devicetree-discuss
mailing list