[PATCH v2] ARM: dt: tegra20: Add GART device

Stephen Warren swarren at wwwdotorg.org
Fri May 4 04:58:39 EST 2012


On 05/03/2012 12:28 PM, Stephen Warren wrote:
> On 04/16/2012 09:04 AM, Thierry Reding wrote:
>> This commit adds the device node required to probe NVIDIA Tegra 20 GART
>> hardware from the device tree.
> 
>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> 
>> +	gart: gart at 7000f000 {
>> +		compatible = "nvidia,tegra20-gart";
>> +		reg = < 0x7000f000 0x00000100    /* controller registers */
>> +		        0x58000000 0x02000000 >; /* GART aperture */
>> +	};
...
> As such, I think this node should be more like:
> 
> mc: mc at 7000f000 {
>     compatible = "nvidia,tegra20-mc";
>     reg = <0x7000f000 0x00000100>;
> };
> 
> Then, one of following options can be taken:
[to represent the fact that MC and GART are essentially the same HW module]
...

Yet another option is to explicitly use the MFD subsystem for this; I
guess options 1 and 3 that I gave were essentially open-coding MFD anyway.

Offline, Hiroshi mentioned that he had looked at MFD, and ended up
thinking it was a rather heavy-weight solution in this case though.


More information about the devicetree-discuss mailing list