[PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically

Mark Brown broonie at opensource.wolfsonmicro.com
Thu May 3 23:20:05 EST 2012


On Thu, May 03, 2012 at 03:54:24PM +0300, Peter Ujfalusi wrote:

>  	/* In order to operate correctly we need valid interrupt config */
> -	if (!client->irq || !pdata->irq_base) {
> +	if (!client->irq) {

It looks like you're totally removing the use of irq_base which will
break any boards that didn't convert to DT.  The usual idiom is to use
irq_base as the base for the range of requested IRQs if it's supplied,
otherwise set it to -1 to allow dynamic allocation.  This should keep
existing users working without disruption.


More information about the devicetree-discuss mailing list