[PATCH v3 1/1] ARM: imx28: add basic dt support

Dong Aisheng aisheng.dong at freescale.com
Fri Mar 30 20:11:51 EST 2012


On Fri, Mar 30, 2012 at 04:51:06PM +0800, Shawn Guo wrote:
> I tried to apply the patch, but ...
> 
> On Fri, Mar 30, 2012 at 02:32:10PM +0800, Dong Aisheng wrote:
> ...
> > +static int __init mxs_icoll_add_irq_domain(struct device_node *np,
> > +				struct device_node *interrupt_parent)
> > +{
> > +	irq_domain_add_simple(np, 0);
> 
> The irq_domain_add_simple() has been removed from mainline.  You need
> a rebase against Linus' tree.
> 
Will rebase.

> > +static struct sys_timer imx28_timer = {
> > +	.init = imx28_timer_init,
> > +};
> > +
> > +static void __init mxs_machine_init(void)
> > +{
> > +       of_platform_populate(NULL, of_default_bus_match_table,
> 
> Given by checkpatch:
> 
> WARNING: please, no spaces at the start of a line
> #565: FILE: arch/arm/mach-mxs/mach-mxs.c:51:
> +       of_platform_populate(NULL, of_default_bus_match_table,$
> 
Hmm, it seems my checkpatch is out of date.
With new checkpatch i found it.

Regards
Dong Aisheng



More information about the devicetree-discuss mailing list