[PATCH] mtd: spear-smi: Update compatible property

viresh kumar viresh.linux at gmail.com
Sun Mar 25 18:25:45 EST 2012


On Fri, Mar 23, 2012 at 7:40 PM, Rob Herring <robherring2 at gmail.com> wrote:
> On 03/23/2012 03:48 AM, Viresh Kumar wrote:
>> SPEAr SMI controller version is same for all SPEAr machines. Thus we don't need
>> per machine compatible property in driver.
>
> Until the next chip...

Sorry couldn't get you point here.

>> Thus this patch updates compatible entry to: "st,spear-smi", so that it
>> works for all SPEAr machines.
>
> There is no reason all machines can't use "st,spear600-smi" in their
> dts. It doesn't have to be a spear600, just compatible with it. Really
> you want the string to be the oldest SOC the block is in and then newer
> SOCs can claim compatibility with the old version.

Got your point. But actually as we just had smi DT support patch recently,
so we can name it better right now. In future, i agree with your point.

> This is also bad that you would break any existing dtb's out there. This
> is probably not a concern yet since it's all new and in transition, but
> down the road this is something that can't be done.

Yes i agree. Actually i had patch for spear600-evb.dts ready with me, but
just wanted to have inputs on this change before posting the complete
patchset.

Would post both patches again, with my 3xx DT support.

--
viresh


More information about the devicetree-discuss mailing list