[PATCH 2/2] Input: spear-keyboard: add device tree bindings

[Stephen Warren]

On 03/26/2012 03:45 AM, Viresh Kumar wrote:
> This adds simple DT bindings for spear-keyboard controller.
...
> diff --git a/Documentation/devicetree/bindings/input/spear-keyboard.txt b/Documentation/devicetree/bindings/input/spear-keyboard.txt
...
> +Required properties:
> +- compatible: "st,spear-kbd"

Should "spear" include some version number so that there's a clear path
if/when future SoCs need a different binding?

> +Optional properties, in addition to those specified by the shared
> +matrix-keyboard bindings:
> +- autorepeat: bool: enables key autorepeat
> +- mode: keyboard mode: 0 - 9x9, 1 - 6x6, 2 - 2x2

mode at least should be "st,mode". autorepeat is probably generic enough
that it doesn't need the vendor prefix.