[PATCH] fdtget-runtest.sh: Fix failures when /bin/sh isn't bash
David Gibson
david at gibson.dropbear.id.au
Mon Mar 26 13:23:50 EST 2012
On Wed, Mar 21, 2012 at 02:26:53PM +1100, David Gibson wrote:
> On Tue, Mar 20, 2012 at 08:23:46PM -0600, Stephen Warren wrote:
> > On Ubuntu, /bin/sh is dash (at least by default), and dash's echo doesn't
> > accept the -e option. This means that fdtget-runtest.sh's EXPECT file will
> > contain "-e foo" rather than just "foo", which causes a test failure.
> >
> > To work around this, run /bin/echo instead of (builtin) echo, which has
> > more chance of supporting the -e option.
> >
> > Another possible fix is to change all the #! lines to /bin/bash rather
> > than /bin/sh, and change run_tests.sh to invoke sub-scripts using $SHELL
> > instead of just "sh". However, that would require bash specifically, which
> > may not be desirable.
> >
> > Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
>
> Acked-by: David Gibson <david at gibson.dropbear.id.au>
>
> Jon, please apply.
Sorry Jon, you fell off the Cc list somehow. Do you need me to resend
Stephen's patch to apply?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
More information about the devicetree-discuss
mailing list