[PATCH 2/3] i2c-s3c2410: Rework device type handling

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Mar 20 06:55:41 EST 2012


On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:

> If you consider code to be inherently less readable because of this
> approach I'll rework it.  If it's not a such big deal for you I would
> prefer to keep it as is.

The thing that was causing me to think the code was funny was mainly the
fact that we're now combining both quirk based selection and chip type
based selection into the same bitmask.  If the chip types were quirks
it'd probably not have looked odd, and that might just be a case of
renaming them - I can't remember what they do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20120319/32cf1b80/attachment.pgp>


More information about the devicetree-discuss mailing list