[PATCH] Don't use non-standard echo options for fdtget-runtest.sh

Simon Glass sjg at chromium.org
Mon Mar 19 13:26:58 EST 2012


Hi John,

On Sun, Mar 18, 2012 at 6:56 PM, David Gibson
<david at gibson.dropbear.id.au> wrote:
> fdtget-runtest.sh currently uses the "-e" option to echo, for interpreting
> string escapes.  But this option is only understood by some versions of
> echo - the one in bash does, but the one in dash does not.  In fact since
> I reworked the fdtget tests a while back, we no longer need the escape
> expanding feature of echo here, so this patch simple removes the -e to
> fix the problem (the testsuite now passes when /bin/sh is dash).
>
> Signed-off-by: David Gibson <david at gibson.dropbear.id.au>

This was put in for this test:

    # Test multiple arguments
    run_fdtget_test "MyBoardName\nmemory" -ts $dtb / model /memory device_type

Without the -e the test fails for me... Do I need a later patch that
has not been applied? I tried with de6b762.

Regards,
Simon

> ---
>  tests/fdtget-runtest.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> index 982fbe1..dac7f9a 100755
> --- a/tests/fdtget-runtest.sh
> +++ b/tests/fdtget-runtest.sh
> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
>  trap "rm -f $LOG $EXPECT" 0
>
>  expect="$1"
> -echo -e $expect >$EXPECT
> +echo $expect >$EXPECT
>  shift
>
>  verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@"
> --
> 1.7.9.1
>


More information about the devicetree-discuss mailing list