[PATCH 14/14] ARM: kirkwood: use devicetree to init sata_mv
Arnd Bergmann
arnd at arndb.de
Thu Mar 8 06:00:47 EST 2012
On Wednesday 07 March 2012, Jason wrote:
> > Is it guaranteed that it's always the first port that gets used if there
> > is only one? If not, this might turn on the wrong one.
>
> This is the same logic as mach-kirkwood/common.c:176
>
> void __init kirkwood_sata_init(struct mv_sata_platform_data *sata_data)
> {
> kirkwood_clk_ctrl |= CGC_SATA0;
> if (sata_data->n_ports > 1)
> kirkwood_clk_ctrl |= CGC_SATA1;
>
> orion_sata_init(sata_data, SATA_PHYS_BASE, IRQ_KIRKWOOD_SATA);
> }
>
> So, I don't think I'm introducing a regression.
Ok, good point. I was wondering whether the individual ports should
be modeled in the device tree, but I guess it's not necessary if nobody
needed this so far.
Arnd
More information about the devicetree-discuss
mailing list