[PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt
Nicolas Pitre
nicolas.pitre at linaro.org
Tue Mar 6 07:43:42 EST 2012
On Mon, 5 Mar 2012, Jason wrote:
> On Mon, Mar 05, 2012 at 08:16:26PM +0000, Arnd Bergmann wrote:
> > On Monday 05 March 2012, Jason wrote:
> > > >
> > > > The clock frequency part being hardcoded to 200000 in the common .dtsi
> > > > file looks wrong. The clock may differ, and it used to (and should) be
> > > > probed at run time, please see kirkwood_find_tclk().
> > >
> > > So, should I EXPORT_SYMBOL_GPL(kirkwood_find_tclk); and have each driver
> > > call it?
> >
> > If the drivers want to use it, I think it has to be orion_find_tclk for
> > drivers that are shared between multiple plat-orion platforms.
>
> That's pretty much all of them :-)
>
> I'll rename it and move it to plat-orion/common.c. This'll be fun.
No no... This is not a function which is generic at all. The _result_
i.e. core clock frequency value is a generic thing, not the method to
determine it.
Nicolas
More information about the devicetree-discuss
mailing list