[PATCH v2 3/7] i2c: pxa: add OF support

Arnd Bergmann arnd at arndb.de
Tue Mar 6 01:41:26 EST 2012


On Monday 05 March 2012, Haojian Zhuang wrote:
> Append these properties in below.
> mrvl,i2c-polling
> mrvl,i2c-fast-mode
> 
> Still keep slave, slave_addr and class in platform data.
> 
> Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>

Acked-by: Arnd Bergmann <arnd at arndb.de>

Just one tiny detail:

> +       *i2c_types = (u32)(of_id->data);

By convention, please use (unsigned long) as the cast from pointer to an
integer type. While this doesn't make any difference on 32 bit systems,
it's better to always write code that is 64-bit clean.

	Arnd


More information about the devicetree-discuss mailing list