[PATCH 3/6] OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC

[John Crispin]

On 28/07/12 01:23, Linus Walleij wrote:
> On Tue, Jul 24, 2012 at 8:50 AM, John Crispin <blogic at openwrt.org> wrote:
>
>> Implement support for pinctrl on lantiq/falcon socs. The FALCON has 5 banks
>> of up to 32 pins.
>>
>> Signed-off-by: John Crispin <blogic at openwrt.org>
>> Signed-off-by: Thomas Langer <thomas.langer at lantiq.com>
>> Cc: Linus Walleij <linus.walleij at linaro.org>
>> Cc: devicetree-discuss at lists.ozlabs.org
>> Cc: linux-kernel at vger.kernel.org
> No big issues and looking really sweet so:
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
>> --- a/arch/mips/lantiq/Kconfig
>> +++ b/arch/mips/lantiq/Kconfig
>> @@ -20,6 +20,7 @@ config SOC_XWAY
>>
>>  config SOC_FALCON
>>         bool "FALCON"
>> +       select PINCTRL_FALCON
> I think you need to add "select PINCTRL" above "select PINCTRL_FALCON"
> for this to work.
>
> Atleast I had to do that in the past to get things working.

Hi Linus,

config LANTIQ selects PINCTRL  globally for all Lantiq SoC so an
explicit select can be avoided here

Thanks for the review,
John