[PATCH] of: support an enumerated-bus compatible value

Grant Likely grant.likely at secretlab.ca
Tue Jul 3 08:37:34 EST 2012


On Mon, Jul 2, 2012 at 4:28 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 07/02/2012 03:43 PM, Grant Likely wrote:
>> On Mon, Jul 2, 2012 at 9:59 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>> On 07/01/2012 04:03 PM, Grant Likely wrote:
>>> ...
>>>> Besides; if they are enumerated, non-memory mapped devices, then is it
>>>> really appropriate to use platform_{device,driver}? I don't think it
>>>> is.
>>>
>>> Hmm, well /everything/ that gets instantiated from DT is a platform
>>> device at present, at least for the platforms and bus types we're using
>>> on Tegra and I believe all/most ARM platforms, except some small amounts
>>> of AMBA.
>>
>> Not true.  SPI devices beget spi_device, i2c devices i2c_client, etc.
>> The appropriate structure for the kind of device should always be
>> used.
>
> Yes, that's true.
>
> But doesn't that lend even more weight to the need for an enumerated-bus
> bus-type/compatible value? After all, the more important issue here (at
> least initially) is the DT representation that we're defining, rather
> than what Linux does with it internally.

... another thought:  If the thing doesn't actually have any kind of
address (like a audio complex) then it probably makes more sense to
drop reg entirely since it is meaningless.  That may not be relevant
for your regulartors example though.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


More information about the devicetree-discuss mailing list