[PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot

Stephen Warren swarren at nvidia.com
Fri Jan 20 07:51:45 EST 2012


On 01/12/2012 12:00 PM, Simon Glass wrote:
> Add U-Boot's peripheral clock information to the Tegra20 device tree file.

> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> index ca7b523..963cf27 100644
> --- a/arch/arm/dts/tegra20.dtsi
> +++ b/arch/arm/dts/tegra20.dtsi
> @@ -45,6 +45,8 @@
>  		compatible = "nvidia,tegra20-i2c";
>  		reg = <0x7000C000 0x100>;
>  		interrupts = < 70 >;
> +		clock-frequency = <100000>;

That's board-specific information. I'd rather not include it in the SoC
.dtsi file even as a default; that way, it forces people to think about
the correct value and put it in their board file, whereas including a
default means people probably won't think about it.

> +		clocks = <&periph_clk 12>;	// PERIPH_ID_I2C1

Of course, that'll need updating based on the resolution of the clock
binding thread I started.

-- 
nvpublic


More information about the devicetree-discuss mailing list