[PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

[Hiremath, Vaibhav]

On Fri, Jan 13, 2012 at 18:31:24, Cousson, Benoit wrote:
> On 1/13/2012 1:31 PM, Hiremath, Vaibhav wrote:
> > On Fri, Jan 13, 2012 at 16:33:07, Cousson, Benoit wrote:
> >> Hi Vaibhav,
> >>
> >> On 1/13/2012 7:14 AM, Hiremath, Vaibhav wrote:
> >>> On Tue, Dec 20, 2011 at 19:09:57, Cousson, Benoit wrote:
> >>
> >> [...]
> >>
> >>>> +++ b/arch/arm/boot/dts/omap3.dtsi
> >>>> @@ -54,10 +54,12 @@
> >>>>    		ranges;
> >>>>    		ti,hwmods = "l3_main";
> >>>>
> >>>> -		intc: interrupt-controller at 1 {
> >>>> -			compatible = "ti,omap3-intc";
> >>>> +		intc: interrupt-controller at 48200000 {
> >>>> +			compatible = "ti,omap2-intc";
> >>>>    			interrupt-controller;
> >>>>    			#interrupt-cells =<1>;
> >>>> +			ti,intc-size =<96>;
> >>> Can we configure/change this field in platform specific .dts file?
> >>> OR
> >>> Is there condition based configuration possible in DT?
> >>
> >> I'm not sure to fully understand how your two options differ.
> >> Otherwise, yes the DT it can be configured, that why I exposed this
> >> attribute.
> >> The intc code was already supporting the ti81xx with 128 lines as well,
> >> hence the need to make it configurable.
> >
> > I wanted to use DT configuration completely here, using existing
> > omap_init_irq.
> > And I personally think, lets not use different implementation only because
> > number of interrupts are different.
> 
> Sure, that was the goal of that binding. Anyway, my point was that the 
> driver was already generic enough to handle OMAP2, OMAP3 and TI81xx.
> 
> >> The other option was two handle that in the driver with 2 different
> >> compatible strings.
> >>
> >>> To be specific,
> >>>
> >>> I am adding support for AM335x EVM (using all your DT support patches),
> >>> The device is considered as OMAP3 variant and when it comes to INTC support,
> >>> I need to configure it to value "128", rest everything is same
> >>> (including base add).
> >>>
> >>> Can I do something like
> >>>
> >>> File - am335x-evm.dts
> >>>
> >>> /include/ "omap3.dtsi"
> >>>
> >>> ....
> >>> Again change the specific fields of " intc: interrupt-controller"?
> >>
> >> Yes.
> >>
> >>> ....
> >>>
> >>> How can this be handled?
> >>
> >> After the include, you can redefine the node and the hierarchy:
> >>
> >> +	ocp {
> >> +		intc: interrupt-controller at 48200000 {
> >> +			ti,intc-size =<128>;
> >> +		};
> >> ...
> >>
> >> or use the label directly:
> >>
> >> +&intc: {
> >> +	ti,intc-size =<128>;
> >> +}
> >>
> >> You can have a look at the way i2c or twl are using the include so far.
> >>
> > Thanks, I will trying this now...
> > And if it works, then I can submit the patches...
> 
> Well, it should in theory :-)
> 

Thanks Benoit, it is working. Submitting patches now...

Thanks,
Vaibhav

> Regards,
> Benoit
>