[PATCH] video: s3c-fb: Add device tree support

Thomas Abraham thomas.abraham at linaro.org
Wed Jan 11 22:04:28 EST 2012


Hi Mark,

On 10 January 2012 10:22, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 10, 2012 at 01:31:47AM +0530, Thomas Abraham wrote:
>
>> +Required properties:
>
>> +- gpios: The gpios used to interface with the external LCD panel.
>
> This isn't terribly informative for the user - which GPIOs and in what
> order are they specified?  Looking at the code it looks like pin mux
> configuration so just some wording saying it's a list of pins to be used
> for the framebuffer function.

Ok. I will modify the sentence to mean that it is list of gpios used
by framebuffer controller for data/timing interface with the lcd
panel. Thanks for your review.

Regards,
Thomas.


More information about the devicetree-discuss mailing list