[PATCH 6/6] mmc: sdhci-s3c: Add device tree support

Thomas Abraham thomas.abraham at linaro.org
Fri Jan 6 02:45:12 EST 2012


Hi Sylwester,

On 4 January 2012 21:07, Sylwester Nawrocki <s.nawrocki at samsung.com> wrote:
> Hi Kgene, Thomas
>
> On 11/08/2011 04:23 PM, Thomas Abraham wrote:
>> Hi Grant,
>>
>> On 8 November 2011 02:47, Grant Likely <grant.likely at secretlab.ca> wrote:
>>> On Thu, Nov 03, 2011 at 02:06:03AM +0530, Thomas Abraham wrote:
>>>> Add device tree based discovery support for Samsung's sdhci controller
>>>>
>>>> Cc: Ben Dooks <ben-linux at fluff.org>
>>>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
>>>> ---
>>>> +Example:
>>>> +     sdhci at 12530000 {
>>>> +             compatible = "samsung,exynos4210-sdhci";
>>>> +             reg = <0x12530000 0x100>;
>>>> +             interrupts = <139>;
>>>> +             samsung,sdhci-bus-width = <4>;
>>>> +             linux,mmc_cap_4_bit_data;
>>>
>>> Following on from my reply on patch 5, this is an example of exactly
>>> what I'm talking about.  This node both sets bus-width to '4', and
>>> sets the 4_bit_data flag.  Don't you think that the driver would be
>>> smart enough to set the 4_bit_data flag when the bus width was set to
>>> 4?
>>
>> Yes, that is true. I will modify the driver based on your comments and
>> resubmit this patch.
>
> Are we going to have those patches in 3.3-rc1 or only in 3.4 ?

Sorry for the delaying in completing this patchset. I will redo this
patchset and submit it soon. But 3.3-rc1 looks unlikely.

Thanks,
Thomas.

>
> --
> Regards,
> Sylwester


More information about the devicetree-discuss mailing list