[PATCH v2 REPOST] dtc: Add support for named integer constants

Simon Glass sjg at chromium.org
Wed Jan 4 11:46:27 EST 2012


Hi Stephen,

On Mon, Dec 12, 2011 at 12:23 PM, Stephen Warren <swarren at nvidia.com> wrote:
> Simon Glass wrote at Monday, December 12, 2011 1:19 PM:
>> On Mon, Dec 12, 2011 at 12:04 PM, Stephen Warren <swarren at nvidia.com> wrote:
>> > You may define constants as follows:
>> >
>> > /define/ TWO 2;
>> > /define/ FOUR 4;
>> > /define/ OTHER FOUR;
>> >
>> > And properties may use these values as follows:
>> >
>> > foo = <1 TWO 3 FOUR 5>;
>> >
>> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
>> > ---
>> > I posted this back in early September. I'd like to ask again that this
>> > feature be merged into dtc; there are many situations where it'd allow
>> > .dts files to be simplified.
>>
>> Yes I agree, it is very useful.
>>
>> I get conflicts with this - does it need a rebase?
>
> Yes, I should have mentioned this patch is still based on the same commit
> it was 3 months ago, and HEAD has moved forward since. If it's deemed
> conceptually acceptable, I'll rebase it to HEAD.
>
> (For reference, it's based on ed8fee1 "Add missing tests to .gitignore".)
>
> --
> nvpublic
>

I haven't seen any other comments. Is this going in? Constants would be useful.

Regards,
Simon


More information about the devicetree-discuss mailing list