[PATCH 1/4 v2] i2c/gpio: add DT support

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Feb 20 21:08:43 EST 2012


On Mon, Feb 20, 2012 at 10:58:13AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:17 Mon 13 Feb     , Karol Lewandowski wrote:
> > > +	- udelay: delay between GPIO operations (may depend on each platform)
> > > +	- timeout: timeout to get data (ms)
> > 
> > 
> > If these are really needed then I would prefer to have these fully
> > qualified (with unit type "-ms/-millisecs" appended).
> > 
> > Regulator framework, with its "-microvolt/-microamp", serve here as
> > prime example of being quite descriptive (one doesn't neet to look up
> > the docs). Please see:
> > 
> >   http://permalink.gmane.org/gmane.linux.ports.arm.omap/67637
> timeout are usualy in ms I don't really see the need of -ms or so

Which is obviously total crap for udelay, which would be in _micro_seconds.



More information about the devicetree-discuss mailing list