[PATCH v5 08/18] tegra: fdt: Add additional USB binding

Simon Glass sjg at chromium.org
Sat Feb 4 03:58:32 EST 2012


Hi Stephen,

On Thu, Feb 2, 2012 at 1:55 PM, Stephen Warren <swarren at nvidia.com> wrote:
> On 01/24/2012 04:21 PM, Simon Glass wrote:
>> This adds a property to indicate a port which can switch between host and device
>> mode.
> ...
>> diff --git a/doc/device-tree-bindings/usb/tegra-usb.txt b/doc/device-tree-bindings/usb/tegra-usb.txt
> ...
>> +Optional properties:
> ...
>> +  - nvidia,has-legacy-mode : boolean indicates whether this controller can
>> +    operate in legacy mode (as APX 2500 / 2600). In legacy mode some
>> +    registers are accessed through the APB_MISC base address instead of
>> +    the USB controller.
>
> I was hoping to represent this as a different compatible value, in the
> same way as one of Tegra's I2C controllers is, eg. nvidia,tegra20-ehci
> and nvidia,tegra20-ehci-legacy.
>
> However, I suppose representing this using a property is OK too.

I prefer this because this is a legacy issue, and I feel that creating
a different compatible node when no one actually uses legacy mode is
an unnecessary complexity.

>
> Either way, can you please also push this patch to the Linux kernel (and
> the associated changes to tegra*.dtsi) in order to run it past the other
> Tegra maintainers before committing to it within U-Boot.

OK I have done this.

>
> Thanks.
>
> --
> nvpublic

Regards,
Simon


More information about the devicetree-discuss mailing list