[PATCH V2 1/2] regulator: tps51632: add register property for regmap

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Dec 28 04:32:33 EST 2012


On Tue, Dec 25, 2012 at 08:35:59PM +0530, Laxman Dewangan wrote:
> All TPS51632 registers are not readable/writable and
> non-volatiles.

Applied both, thanks, but you might wish to consider...

> +static bool is_read_reg(struct device *dev, unsigned int reg)
> +{
> +	switch (reg) {
> +	case 0x08 ... 0x0F:
> +		return false;
> +	default:
> +		return true;
> +	}
> +}

...using the new table based stuff for the access checks, at least this
one seems to map on nicely.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20121227/79ae4ba3/attachment.sig>


More information about the devicetree-discuss mailing list