[PATCH V6] mfd: stmpe: Update DT support for stmpe driver

Viresh Kumar viresh.kumar at linaro.org
Fri Dec 7 03:47:21 EST 2012


On 6 December 2012 22:10, Lee Jones <lee.jones at linaro.org> wrote:
> On Thu, 06 Dec 2012, Viresh Kumar wrote:
>> +     pdata->id = -1;
>
> Perhaps PLATFORM_DEVID_AUTO would be better?

Why do we want to allocate device id's for it? Multiple devices
are already distinguished and so -1 would be better.

>> +     pdata->irq_trigger = IRQF_TRIGGER_NONE;
>> +
>
> There's no need for this. It's guaranteed to be zero by:
>
>   pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);

I kept it so that in future others don't think that we missed handling
of irq_trigger for DT case.

--
viresh


More information about the devicetree-discuss mailing list