[PATCH V5 2/2] mfd: stmpe: Update DT support in stmpe driver

Viresh Kumar viresh.kumar at linaro.org
Thu Dec 6 13:36:20 EST 2012


On 6 December 2012 04:12, Grant Likely <grant.likely at secretlab.ca> wrote:
> On Sat, 1 Dec 2012 00:33:46 +0530, Viresh Kumar <viresh.kumar at linaro.org> wrote:
>> This first tries to match the table my patch added, _BUT_ the string will
>> never match as we had "st,stmpe810" in table and "stmpe810" in dev.
>
> of_driver_match_device() matches against the compatible list in
> dev->of_node, not against the device name. So, if the compatible
> property has a string that is in the table, then it really should match
> against it.

Grant, but isn't it true that the final device's name would not be the DT
way of names? It would simply be "stmpe810" for us and so if we have
multiple instances of stmpe on a board, we need to distinguish them
ourselves? One way for that was passing id for these instances, which
would finally be used, when we create platform devices for sub-modules
of stmpe (gpio, keypad, ts, etc).

--
viresh


More information about the devicetree-discuss mailing list