[PATCH] dt: fsl-fec.txt: Fix GPIO comment and remove hardcoded MAC address

Shawn Guo shawn.guo at linaro.org
Tue Apr 24 16:31:47 EST 2012


On 24 April 2012 11:58, Fabio Estevam <festevam at gmail.com> wrote:
> Fix the comment for the GPIO number used for PHY reset and also avoid passing a
> hardcoded MAC address.
>
You can choose to not pass MAC address from device tree, but someone
may want to use it for some case, e.g. local network just for
debugging.  In any case, it's a binding supported by driver, you can
choose not use it, but you can not remove it from the binding doc.

Regards,
Shawn

> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  Documentation/devicetree/bindings/net/fsl-fec.txt |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
> index de43951..3261203 100644
> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
> +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
> @@ -9,9 +9,6 @@ Required properties:
>   "rgmii", "rgmii-id", "rgmii-rxid", "rgmii-txid", "rtbi", "smii".
>  - phy-reset-gpios : Should specify the gpio for phy reset
>
> -Optional properties:
> -- local-mac-address : 6 bytes, mac address
> -
>  Example:
>
>  fec at 83fec000 {
> @@ -19,6 +16,5 @@ fec at 83fec000 {
>        reg = <0x83fec000 0x4000>;
>        interrupts = <87>;
>        phy-mode = "mii";
> -       phy-reset-gpios = <&gpio1 14 0>; /* GPIO2_14 */
> -       local-mac-address = [00 04 9F 01 1B B9];
> +       phy-reset-gpios = <&gpio1 14 0>; /* GPIO1_14 */
>  };
> --
> 1.7.1
>


More information about the devicetree-discuss mailing list