[PATCH] pinctrl: add error message to pinmux_map_to_setting's error path

John Crispin blogic at openwrt.org
Tue Apr 24 04:49:34 EST 2012


> There are some other cases where more error messages would be useful,
> such as invalid function name, invalid config options etc. I was
> planning on going through the code and adding these since some of these
> are hitting me on a new board I'm adding to mainline. Are you planning
> to add more of these messages, or should I go ahead with that?

I am in the process of converting the mips/lantiq/ target to OF and
pinctrl amongst over things.
i stumbled across the 2 patches i mailed today. i will be able to spare
a couple of hours tomorrow
to see if i can find more places where debug output would make sense.


> I wonder if the message would be more useful if it said something like
> "invalid group %s for function %s" - that would give a little more
> information for the user to track down the incorrect entry, since that
> group name may be valid in general, just not for the function being
> converted.
that is the case. lets see what i can come up with.


> BTW, the "Cc" you added to the commit description doesn't appear to be
> happening; I'm only receiving this message through the list.
I realized this aswell, although i am subscribed to the list (even
checked if i subscribed with this mail addr) .
i will check the server logs and contact the list admins to see whats up






More information about the devicetree-discuss mailing list