[RFC 2/4] iommu: tegra/gart: Add device tree support

Thierry Reding thierry.reding at avionic-design.de
Thu Apr 12 16:51:09 EST 2012


* Stephen Warren wrote:
> On 04/11/2012 06:10 AM, Thierry Reding wrote:
> > This commit adds device tree support for the GART hardware available on
> > NVIDIA Tegra 20 SoCs.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>
> > ---
> >  arch/arm/boot/dts/tegra20.dtsi         |    6 ++++++
> >  arch/arm/mach-tegra/board-dt-tegra20.c |    1 +
> >  drivers/iommu/tegra-gart.c             |   10 ++++++++++
> >  3 files changed, 17 insertions(+)
> 
> I think I'd prefer at least the tegra20.dtsi change split out into a
> separate patch so I can queue it in a "dt" topic branch in the Tegra repo.
> 
> It might be a good idea to split this into two on an arch/arm vs.
> drivers/iommu boundary. Looking at Olof's branches for 3.4, that split
> is what happened there.
> 
> Finally, there should be a binding documentation file in
> Documentation/devicetree/bindings in order to specify the number of reg
> property entries needed, and their meaning, since there's more than 1
> (even though you did comment it nicely in the .dtsi file)

Okay, I'll do that.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20120412/9c62bb0d/attachment.sig>


More information about the devicetree-discuss mailing list