[PATCH 3/5] powerpc: dts: klondike: Add UART nodes

[Tanmay Inamdar]

On Wed, Apr 4, 2012 at 6:19 AM, Josh Boyer <jwboyer at gmail.com> wrote:
> On Tue, Apr 3, 2012 at 11:57 AM, Grant Likely <grant.likely at secretlab.ca> wrote:
>> On Mon,  2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <tinamdar at apm.com> wrote:
>>> Adding UART nodes in Klondike device tree file.
>>>
>>> Signed-off-by: Tanmay Inamdar <tinamdar at apm.com>
>>> ---
>>> :100644 100644 4ff2852... d5bf2e1... M        arch/powerpc/boot/dts/klondike.dts
>>>  arch/powerpc/boot/dts/klondike.dts |   24 ++++++++++++++++++++++++
>>>  1 files changed, 24 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
>>> index 4ff2852..d5bf2e1 100644
>>> --- a/arch/powerpc/boot/dts/klondike.dts
>>> +++ b/arch/powerpc/boot/dts/klondike.dts
>>> @@ -222,6 +222,30 @@
>>>                               #size-cells = <1>;
>>>                               ranges;
>>>                               clock-frequency = <0>;
>>> +
>>> +                             UART0: serial at 50001000 {
>>> +                                    device_type = "serial";
>>> +                                    compatible = "ns16550";
>>> +                                    reg = <0x50001000 0x00000100>;
>>> +                                    virtual-reg = <0x50001000>;
>>
>> Why do you need virtual-reg?  The kernel should handle all iomapping
>> properly without this.
>
> Right.  It's been used for platforms that actually use the
> zImage/treeImage wrapper for printf support, but this uses u-boot as
> far as I know.  It shouldn't need it.
>

Agreed. 'virtual-reg' is not required here. I will remove it in next
version of patch.

> josh
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, 
is for the sole use of the intended recipient(s) and contains information 
that is confidential and proprietary to AppliedMicro Corporation or its subsidiaries. 
It is to be used solely for the purpose of furthering the parties' business relationship. 
All unauthorized review, use, disclosure or distribution is prohibited. 
If you are not the intended recipient, please contact the sender by reply e-mail 
and destroy all copies of the original message.