[PATCH 1/2] arm/dt: add basic usb nodes to tegra device trees

Grant Likely grant.likely at secretlab.ca
Sat Nov 5 05:20:05 EST 2011


On Fri, Nov 4, 2011 at 11:27 AM, Stephen Warren <swarren at nvidia.com> wrote:
> Olof Johansson wrote at Thursday, November 03, 2011 9:26 PM:
>> For now they are a minimal binding. It needs to be amended with
>> vendor-specific settings for phy setup and link tuning, etc.
> ...
>> diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts
> ...
>> +     usb at c5000000 {
>> +             nvidia,vbus-gpio = <&gpio 24 0>; /* PD0 */
>> +     };
>
> Given that's a custom property, don't we need bindings documentation in
> Documentation/devictree/bindings/usb/? Even if the binding is pretty self-
> explanatory.

Yes, you're right.  Please add a binding, but you can leave my ack in
place when reposted.

g.


More information about the devicetree-discuss mailing list