[RFC 2/2] ARM:Tegra: Device Tree Support: Initialize audio card gpio's from the device tree.
Mark Brown
broonie at opensource.wolfsonmicro.com
Mon May 30 13:38:27 EST 2011
On Sun, May 29, 2011 at 08:11:34PM -0700, Olof Johansson wrote:
> On Fri, May 27, 2011 at 6:24 PM, Mark Brown
> > This is a step back from the usability of the existing platform data -
> > the platform data uses a series of individually named GPIOs while this
> > uses an array of GPIO numbers with magic indexes. The fact that you
> > need comments explaining what the functions of the array elements are
> > is a bit of a red flag here.
> Agreed, I had similar concerns with the sdhci bindings where it used a
> 3-element array of gpios instead of the previous named ones. I was
> told it's common practice to do it that way though? Seems like a step
> backwards to me. :(
Interesting... what was the reasoning behind this? It's a definite
step backwards but it does explain my major concern with the new batch
of device tree patches.
More information about the devicetree-discuss
mailing list