[PATCH 2/2] drivercore: revert addition of of_match to struct device

Greg KH gregkh at suse.de
Thu May 19 05:55:14 EST 2011


On Wed, May 18, 2011 at 01:21:05PM -0600, Grant Likely wrote:
> Commit b826291c, "drivercore/dt: add a match table pointer to struct
> device" added an of_match pointer to struct device to cache the
> of_match_table entry discovered at driver match time.  This was unsafe
> because matching is not an atomic operation with probing a driver.  If
> two or more drivers are attempted to be matched to a driver at the
> same time, then the cached matching entry pointer could get
> overwritten.
> 
> This patch reverts the of_match cache pointer and reworks all users to
> call of_match_device() directly instead.
> 
> Signed-off-by: Grant Likely <grant.likely at secretlab.ca>

Acked-by: Greg Kroah-Hartman <gregkh at suse.de>


More information about the devicetree-discuss mailing list