[PATCH v5] uio/pdrv_genirq: Add OF support

[Thomas De Schampheleire]

Hi,

On Fri, May 6, 2011 at 2:47 AM, Hans J. Koch <hjk at hansjkoch.de> wrote:

> On Thu, May 05, 2011 at 08:40:44AM +0200, Michal Simek wrote:
>
> I think we've got it.
>
> Thanks,
> Hans
>
> > Adding OF binding to genirq.
> > Version string is setup to the "devicetree".
> >
> > Compatible string is not setup for now but you can add your
> > custom compatible string to uio_of_genirq_match structure.
> >
> > For example with "vendor,device" compatible string:
> > static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> >       { .compatible = "vendor,device", },
> >       { /* empty for now */ },
> > };
> >
> > Signed-off-by: Michal Simek <monstr at monstr.eu>
>
> Signed-off-by: Hans J. Koch <hjk at hansjkoch.de>
>
> > CC: Hans J. Koch <hjk at hansjkoch.de>
> > CC: Arnd Bergmann <arnd at arndb.de>
> > CC: John Williams <john.williams at petalogix.com>
> > CC: Grant Likely <grant.likely at secretlab.ca>
> > CC: Wolfram Sang <w.sang at pengutronix.de>
>

Sorry for adding to this discussion so late...

I fail to see how a device described in the device tree can be bound to this
generic driver, as the match table is empty. I read in the description:

> Compatible string is not setup for now but you can add your
> custom compatible string to uio_of_genirq_match structure.
>
> For example with "vendor,device" compatible string:
> static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
>       { .compatible = "vendor,device", },
>       { /* empty for now */ },
> };

So, this would mean that for a given project, you need to modify the sources
of the *generic* driver ?

Thanks for clarifying,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20110512/c74bc1c1/attachment.html>