checking status semantics with compatible functions

Kumar Gala galak at
Wed Mar 30 19:07:57 EST 2011


We have a few helper functions like:


That we use in places like arch/powerpc/platform/85xx/mpc85xx_ds.c:

        for_each_node_by_type(np, "pci") {
                if (of_device_is_compatible(np, "fsl,mpc8540-pci") ||
                    of_device_is_compatible(np, "fsl,mpc8548-pcie") ||
                    of_device_is_compatible(np, "fsl,p2020-pcie")) {

It seems like we should check 'status' in these cases with 'of_device_is_available'.  I'm thinking that we should have versions of the helpers that also do the 'of_device_is_available' checking.  Or should we just change the helpers to call of_device_is_available?

- k

More information about the devicetree-discuss mailing list