[PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

Shawn Guo shawn.guo at freescale.com
Tue Mar 8 14:46:47 EST 2011


On Tue, Mar 08, 2011 at 11:31:07AM +0800, Jason Hui wrote:
> Hi, Shawn,
> 
> On Tue, Mar 8, 2011 at 11:11 AM, Shawn Guo <shawn.guo at freescale.com> wrote:
> > On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote:
> >> Hi, Shawn,
> >>
> >> On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo <shawn.guo at freescale.com> wrote:
> >> > Aha, Jason.  Grant and I put many comments on v1 of this patch, but it
> >> > seems that v2 is identical to v1, except adding Rob Herring sign-off.
> >>
> >> Please compare with v1 and say it once again, It should include the
> >
> > Oops!  Sorry, I messed up with my local branches last night, probably
> > because it was late :)
> >
> >> grant and your comments except the mxctty1
> >> due to I think that it's not one issue, So, I did not take your comments.
> >>
> > I still think it's an issue that the dt kernel needs a different
> > console cmdline from the non-dt one.
> 
> In fact, this is user defined, I think But why we need mxctty1 in dt
> here, the reason is that,
> 
> uart3 will be probed first and then uart0, uart1, which lead to
> mxctty0 ---> uart3,
> 
> mxctty1---> uart0 and mxctty2 --->uart1.
> 
> The debug uart of mx51 babbage board is uart0, so we need define
> mxctty1 in the kernel command line.
> 
> We can put spba at 70000000 at the back of aips at 73f00000, but it will
> make the memory address not sorted
> from lower to higher.
> 
> 
> spba at 70000000 {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 compatible = "simple-bus";
>                 ranges = <0x0 0x70000000 0x100000>;
> 
>                 imx-uart at c000 {
>                         compatible = "fsl,imx51-uart";
>                         reg = <0xc000 0x1000>;
>                         interrupts = <0x21>;
>                         rts-cts;
>                         uart-clock = <&uart2_clk>, "uart";
>                 };
>         };
> 
>         aips at 73f00000 {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 compatible = "simple-bus";
>                 ranges = <0x0 0x73f00000 0x100000>;
> 
>                 imx-uart at bc000 {
>                         compatible = "fsl,imx51-uart";
>                         reg = <0xbc000 0x1000>;
>                         interrupts = <0x1f>;
>                         fsl,has-rts-cts;
>                         uart-clock = <&uart0_clk>, "uart";
>                 };
> 
>                 imx-uart at c0000 {
>                         compatible = "imx-uart";
>                         reg = <0xc0000 0x1000>;
>                         interrupts = <0x20>;
>                         fsl,has-rts-cts;
>                         uart-clock = <&uart1_clk>, "uart";
>                 };
> 
> 
So we probably need one more number in 'reg' to tell the port id?

-- 
Regards,
Shawn



More information about the devicetree-discuss mailing list