[PATCH 1/4] ARM:boot:device tree: Allow the device tree binary to be appended to zImage
Nicolas Pitre
nicolas.pitre at linaro.org
Wed Mar 2 13:37:51 EST 2011
On Tue, 1 Mar 2011, John Bonesio wrote:
> I have looked through, and I'm reworking the patch set. I have just one
> comment below.
>
> - John
>
> On 02/28/2011 10:39 PM, Nicolas Pitre wrote:
> > On Mon, 28 Feb 2011, John Bonesio wrote:
> >
[...]
> >> +
> >> + /* bump our bss registers too */
> >> + add r2, r2, r5
> >> + add r3, r3, r5
> >> +
> >> + /* bump the stack pinter, if at or above _edata */
> >> + cmp sp, r6
> >> + addcs sp, sp, r5
> >
> > This will always be true as this is within #ifndef CONFIG_ZBOOT_ROM.
>
> Right now sp will always be above r6. I thought it might be prudent to
> add the test in case the linker script changed and the stack was placed
> elsewhere. It might save someone a headache later.
That's what comments are for. And if someone modifies the linker script
without understanding the affected code then that someone deserves the
pain.
Nicolas
More information about the devicetree-discuss
mailing list