[PATCH 2/4] ARM:boot:device tree: Merge specific atags into the device tree
John Bonesio
bones at secretlab.ca
Tue Mar 1 10:33:38 EST 2011
This patch is to merge in key atags into the appended device tree. An appended
device tree is where the zImage has a dtb binary appended at the end of it. The
boot code looks for an appended device tree, then looks for a few key atags
passed in by the bootloader.
The bootargs and memory size settings, if they exist, override existing values
in the appended device tree. If these values don't currently exist in the
appended device tree, they are added.
Signed-off-by: John Bonesio <bones at secretlab.ca>
---
arch/arm/boot/compressed/Makefile | 31 ++++++++++++++--
arch/arm/boot/compressed/atags.c | 70 +++++++++++++++++++++++++++++++++++++
arch/arm/boot/compressed/head.S | 15 ++++++++
arch/arm/boot/compressed/misc.c | 58 ++++++++++++++++++++++++++++++-
4 files changed, 167 insertions(+), 7 deletions(-)
create mode 100644 arch/arm/boot/compressed/atags.c
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 9d328be..7a2fe22 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -49,6 +49,10 @@ ifeq ($(CONFIG_ARCH_SHMOBILE),y)
OBJS += head-shmobile.o
endif
+ifeq ($(CONFIG_ARM_APPENDED_DTB),y)
+OBJS += atags.o libfdt.a
+endif
+
#
# We now have a PIC decompressor implementation. Decompressors running
# from RAM should not define ZTEXTADDR. Decompressors running directly
@@ -80,7 +84,9 @@ ORIG_CFLAGS := $(KBUILD_CFLAGS)
KBUILD_CFLAGS = $(subst -pg, , $(ORIG_CFLAGS))
endif
-EXTRA_CFLAGS := -fpic -fno-builtin
+fdttree := $(srctree)/scripts/dtc/libfdt
+
+EXTRA_CFLAGS := -fpic -fno-builtin -I$(fdttree) -I$(obj)
EXTRA_AFLAGS := -Wa,-march=all
# Provide size of uncompressed kernel to the decompressor via a linker symbol.
@@ -102,13 +108,28 @@ LDFLAGS_vmlinux += -X
LDFLAGS_vmlinux += -T
# For __aeabi_uidivmod
-lib1funcs = $(obj)/lib1funcs.o
+libfuncs = $(obj)/lib1funcs.o
-$(obj)/lib1funcs.S: $(srctree)/arch/$(SRCARCH)/lib/lib1funcs.S FORCE
- $(call cmd,shipped)
+ifeq ($(CONFIG_ARM_APPENDED_DTB),y)
+# For memchr, memmove, etc
+libfuncs += $(obj)/memchr.o $(obj)/strchr.o $(obj)/memmove.o $(obj)/memzero.o
+endif
+
+
+libfdtheader := $(fdttree)/fdt.h $(fdttree)/libfdt.h $(fdttree)/libfdt_internal.h
+libfdtobj := $(obj)/fdt.o $(obj)/fdt_ro.o $(obj)/fdt_wip.o $(obj)/fdt_sw.o $(obj)/fdt_rw.o $(obj)/fdt_strerror.o
+
+$(libfdtobj): $(obj)/%.o: $(srctree)/scripts/dtc/libfdt/%.c $(libfdtheader)
+ $(call cmd_cc_o_c)
+
+$(obj)/libfdt.a: $(libfdtobj)
+ $(AR) rcs $@ $^
+
+$(libfuncs): $(obj)/%.o: $(srctree)/arch/$(SRCARCH)/lib/%.S
+ $(call cmd_as_o_S)
$(obj)/vmlinux: $(obj)/vmlinux.lds $(obj)/$(HEAD) $(obj)/piggy.$(suffix_y).o \
- $(addprefix $(obj)/, $(OBJS)) $(lib1funcs) FORCE
+ $(addprefix $(obj)/, $(OBJS)) $(libfuncs) FORCE
$(call if_changed,ld)
@:
diff --git a/arch/arm/boot/compressed/atags.c b/arch/arm/boot/compressed/atags.c
new file mode 100644
index 0000000..d19d53d
--- /dev/null
+++ b/arch/arm/boot/compressed/atags.c
@@ -0,0 +1,70 @@
+#include <stddef.h>
+#include <asm/byteorder.h>
+#include <asm/setup.h>
+#include <fdt.h>
+#include <libfdt.h>
+
+int dt_setprop(void *fdt, const char *node_path, const char *property,
+ uint32_t *val_array, int size)
+{
+ int offset;
+
+ offset = fdt_path_offset(fdt, node_path);
+ if (offset < 0)
+ return offset;
+
+ return fdt_setprop(fdt, offset, property, val_array, size);
+}
+
+int dt_setprop_string(void *fdt, const char *node_path,
+ const char *property, const char *string)
+{
+ int offset;
+
+ offset = fdt_path_offset(fdt, node_path);
+ if (offset < 0)
+ return offset;
+
+ return fdt_setprop_string(fdt, offset, property, string);
+}
+
+int dt_setprop_cell(void *fdt, const char *node_path,
+ const char *property, uint32_t val)
+{
+ int offset;
+
+ offset = fdt_path_offset(fdt, node_path);
+ if (offset < 0)
+ return offset;
+
+ return fdt_setprop_cell(fdt, offset, property, val);
+}
+
+void dt_merge_atags(void *dt, void *ataglist)
+{
+ struct tag *atag = ataglist;
+ uint32_t mem_reg_property[2];
+ uint32_t initrd_start, initrd_size;
+ int rc;
+
+ while (atag && atag->hdr.tag != 0) {
+ if (atag->hdr.tag == ATAG_CMDLINE) {
+ dt_setprop_string(dt, "/chosen", "bootargs",
+ atag->u.cmdline.cmdline);
+ } else if (atag->hdr.tag == ATAG_MEM) {
+ mem_reg_property[0] = cpu_to_fdt32(atag->u.mem.start);
+ mem_reg_property[1] = cpu_to_fdt32(atag->u.mem.size);
+ dt_setprop(dt, "/memory", "reg", mem_reg_property,
+ sizeof(mem_reg_property));
+ } else if (atag->hdr.tag == ATAG_INITRD2) {
+ initrd_start = atag->u.initrd.start;
+ initrd_size = atag->u.initrd.size;
+ dt_setprop_cell(dt, "/chosen", "linux,initrd-start",
+ initrd_start);
+ dt_setprop_cell(dt, "/chosen", "linux,initrd-end",
+ initrd_start + initrd_size);
+ }
+ atag = tag_next(atag);
+ }
+}
+
diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
index ae9f8c6..c2cdc5f 100644
--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -211,6 +211,7 @@ restart: adr r0, LC0
mov r10, r6
#endif
#ifdef CONFIG_ARM_APPENDED_DTB
+#define MERGE_SPACE 1024
/*
* r0 = delta
* r2 = BSS start
@@ -243,6 +244,8 @@ restart: adr r0, LC0
mov r12, r12, ror #8
eor r12, r12, r1, lsr #8
+ add r12, r12, #MERGE_SPACE @ extra space to merge in atags
+
add r10, r10, r12
add r6, r6, r12
@@ -338,6 +341,8 @@ wont_overwrite:
@ ... GOT entry doesn't
@ ... overwrite end of image
+ add r5, r5, #MERGE_SPACE @ extra space to merge in atags
+
1: ldr r1, [r11, #0] @ relocate entries in the GOT
add r1, r1, r0 @ table. This fixes up the
cmp r1, r2
@@ -396,6 +401,16 @@ wont_overwrite:
cmp r0, r1
bne keep_atags
+#ifndef CONFIG_ZBOOT_ROM
+ ldr r0, [r6, #4]
+ add r0, r0, #MERGE_SPACE
+ str r0, [r6, #4] @ increase device tree size
+
+ /* merge in some key atags into the dtb */
+ mov r0, r6
+ mov r1, r8
+ bl dt_merge_atags
+#endif
mov r8, r6 @ use the appended device tree
keep_atags:
#endif
diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index e653a6d..2d4da4c 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -29,7 +29,7 @@ unsigned int __machine_arch_type;
#include <asm/unaligned.h>
-static void putstr(const char *ptr);
+void putstr(const char *ptr);
extern void error(char *x);
#include <mach/uncompress.h>
@@ -100,7 +100,7 @@ static void icedcc_putc(int ch)
#define putc(ch) icedcc_putc(ch)
#endif
-static void putstr(const char *ptr)
+void putstr(const char *ptr)
{
char c;
@@ -114,6 +114,60 @@ static void putstr(const char *ptr)
}
+#ifdef CONFIG_ARM_APPENDED_DTB
+/**
+ * strlen - Find the length of a string
+ * @s: The string to be sized
+ */
+size_t strlen(const char *s)
+{
+ const char *sc;
+
+ for (sc = s; *sc != '\0'; ++sc)
+ /* nothing */;
+ return sc - s;
+}
+
+/**
+ * strcmp - Compare two strings
+ * @cs: One string
+ * @ct: Another string
+ */
+#undef strcmp
+int strcmp(const char *cs, const char *ct)
+{
+ unsigned char c1, c2;
+
+ while (1) {
+ c1 = *cs++;
+ c2 = *ct++;
+ if (c1 != c2)
+ return c1 < c2 ? -1 : 1;
+ if (!c1)
+ break;
+ }
+ return 0;
+}
+
+/**
+ * memcmp - Compare two areas of memory
+ * @cs: One area of memory
+ * @ct: Another area of memory
+ * @count: The size of the area.
+ */
+#undef memcmp
+int memcmp(const void *cs, const void *ct, size_t count)
+{
+ const unsigned char *su1, *su2;
+ int res = 0;
+
+ for (su1 = cs, su2 = ct; 0 < count; ++su1, ++su2, count--)
+ if ((res = *su1 - *su2) != 0)
+ break;
+ return res;
+}
+#endif
+
void *memcpy(void *__dest, __const void *__src, size_t __n)
{
int i = 0;
More information about the devicetree-discuss
mailing list