[PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data
Lothar Waßmann
LW at KARO-electronics.de
Mon Jul 11 17:15:34 EST 2011
Hi,
Shawn Guo writes:
> spi_imx_devtype_data has already been driver private data. There is
> really no need to make a copy in spi_imx_data. Instead, a reference
> pointer works perfectly fine.
>
You obviously overlooked, that the copy is done on purpose to keep
only the data that is actually needed and discard everything else
after initialisation.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
More information about the devicetree-discuss
mailing list