[PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness

Daniel Drake dsd at laptop.org
Thu Feb 24 07:06:47 EST 2011


On 23 February 2011 19:54, Andres Salomon <dilinger at queued.net> wrote:
>> Wait; why are you binding to a device based on name?  Binding by name
>> and/or device_type is strongly discouraged for new code.  Use
>> compatible instead.
>>
>
> Daniel posted a separate patch showing his code, would you mind
> commenting on that?  I noticed he didn't cc you though, here's the
> patch:
>
> https://patchwork.kernel.org/patch/574901/

It does bind to the name.
We don't currently have a compatible property for the battery device.
We could fix that with a firmware upgrade, but it would break
compatibility with all existing installs. I guess this is still the
recommended approach...

Daniel


More information about the devicetree-discuss mailing list