[PATCH 1/2] sound/soc/fsl/p1022_ds.c: add missing of_node_put

Timur Tabi timur at freescale.com
Mon Aug 22 23:55:28 EST 2011


Julia Lawall wrote:
> From: Julia Lawall <julia at diku.dk>
>
> dma_channel_np has been accessed at this point, so decrease its reference
> count before leaving the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> expression E1!=0,E2,E3,E4;
> statement S;
> iterator I;
> @@
>
> (
> if (...) { ... when != of_node_put(x)
>                when != x = E3
>                when != E3 = x
> *  return ...;
>  }
> ... when != x = E2
>     when != I(...,x,...) S
> if (...) { ... when != x = E4
>  of_node_put(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia at diku.dk>

Acked-by: Timur Tabi <timur at freescale.com>

Thanks, Julia.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the devicetree-discuss mailing list