[PATCH 1/3] vic: add device tree bindings
Jamie Iles
jamie at jamieiles.com
Mon Aug 1 01:27:14 EST 2011
On Sat, Jul 30, 2011 at 10:11:07PM -0600, Grant Likely wrote:
> On Mon, Jul 25, 2011 at 11:31:51PM +0100, Jamie Iles wrote:
> >
> > > > + }
> > >
> > > I think that rather than writing a interrupt-controller-specific
> > > parse route like this one, it would be much better to have a generic
> > > helper that finds and sorts all the interrupt controllers before
> > > calling a setup callback for each one.
> >
> > Hmm, not sure I follow this. I can see that many controllers would have
> > some common properties so there will be some common code - are you
> > suggesting having something do all the parsing then callbacks for each
> > controller type that takes some kind of template or am I way off the
> > mark?
>
> No, I'm more talking about having a routine that finds all the
> interrupt controllers and figures out the cascading order, and then
> calls each irq controller setup routine in order.
OK, that makes sense. I'm not sure how best to implement that but I'll
give it some thought.
Regarding the irq-start property - on picoxcell we have 2 VIC's and they
aren't cascaded - the outputs are just OR'd together so I can't work out
how to fit in the IRQ decoding with get_irqnr_and_base without having
this property. Is there another way that I could implement that?
Jamie
More information about the devicetree-discuss
mailing list