[PATCH] arm/dt: Add basic device tree support for mx53 loco board

Shawn Guo shawn.guo at freescale.com
Fri Apr 1 03:36:16 EST 2011


Hi Grant,

On Wed, Mar 30, 2011 at 09:52:15PM -0600, Grant Likely wrote:
> On Tue, Mar 29, 2011 at 10:34:12AM +0000, Liu Hui-R64343 wrote:
> > Hi, Grant,
> > The two patches for mx51/mx53 DT support have the same issue, which 
> > is the S-O-B will be missed when you git am. Let me know if you want me
> > re-send the two patches or you would take care when you am it? Thanks,
> 
> I fixed it up.  Don't worry about it.
> 
I'm little confused by the Kconfig changes in this patch.  I saw your
comments on SMDKV310 patch as below.  But this patch was accepted with
MX5_DT_COMMON selected, which in turn selects USE_OF and
PROC_DEVICETREE.

--- quota begins ---
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index a021b52..78f5924 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -123,6 +123,7 @@ config MACH_SMDKV310
>  	select EXYNOS4_SETUP_I2C1
>  	select EXYNOS4_SETUP_KEYPAD
>  	select EXYNOS4_SETUP_SDHCI
> +	select USE_OF

I would drop this bit (I dropped it from my branch when I applied the
patch).  Device tree support remains an optional feature.  Instead it
can be enabled by default in the defconfig (or however the config is
managed for the kernel package)
--- quota ends ---

BTW, are you silently renaming the original devicetree/test branch
to devicetree/test-2.6.38 and using new devicetree/test for Nicolas
to pull Linaro bits?  If that is the case, what branch
devicetree/arm-linaro-2.6.38-rebuilt will be for?

-- 
Regards,
Shawn



More information about the devicetree-discuss mailing list