[PATCH 1/7] of: GPIO: Fix OF probing on little-endian systems
Grant Likely
grant.likely at secretlab.ca
Wed Sep 29 16:30:11 EST 2010
On Wed, Sep 29, 2010 at 03:52:12PM +1000, Michal Simek wrote:
> DTB is always big-endian that's why is necessary
> to convert it.
>
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> CC: Grant Likely <grant.likely at secretlab.ca>
> CC: Tejun Heo <tj at kernel.org>
> CC: Anton Vorontsov <avorontsov at ru.mvista.com>
> CC: linux-kernel at vger.kernel.org
> CC: devicetree-discuss at lists.ozlabs.org
Applied, thanks.
g.
> ---
> drivers/gpio/xilinx_gpio.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
> index 7096909..846fbd5 100644
> --- a/drivers/gpio/xilinx_gpio.c
> +++ b/drivers/gpio/xilinx_gpio.c
> @@ -171,13 +171,13 @@ static int __devinit xgpio_of_probe(struct device_node *np)
> /* Update GPIO state shadow register with default value */
> tree_info = of_get_property(np, "xlnx,dout-default", NULL);
> if (tree_info)
> - chip->gpio_state = *tree_info;
> + chip->gpio_state = be32_to_cpup(tree_info);
>
> /* Update GPIO direction shadow register with default value */
> chip->gpio_dir = 0xFFFFFFFF; /* By default, all pins are inputs */
> tree_info = of_get_property(np, "xlnx,tri-default", NULL);
> if (tree_info)
> - chip->gpio_dir = *tree_info;
> + chip->gpio_dir = be32_to_cpup(tree_info);
>
> /* Check device node and parent device node for device width */
> chip->mmchip.gc.ngpio = 32; /* By default assume full GPIO controller */
> @@ -186,7 +186,7 @@ static int __devinit xgpio_of_probe(struct device_node *np)
> tree_info = of_get_property(np->parent,
> "xlnx,gpio-width", NULL);
> if (tree_info)
> - chip->mmchip.gc.ngpio = *tree_info;
> + chip->mmchip.gc.ngpio = be32_to_cpup(tree_info);
>
> spin_lock_init(&chip->gpio_lock);
>
> --
> 1.5.5.1
>
More information about the devicetree-discuss
mailing list